-
Notifications
You must be signed in to change notification settings - Fork 124
Remove deprecated Google Mobile Ads (GMA) C++ SDK #1768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonsimantov
wants to merge
7
commits into
main
Choose a base branch
from
remove-gma-sdk-july-2025
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the entire GMA C++ SDK from the Firebase C++ SDK, including all references to it across all platforms (iOS, Desktop, and Android). Changes include: - Deletion of the core `gma` directory and its contents. - Removal of GMA from CMakeLists.txt files. - Removal of GMA from Gradle build files. - Removal of GMA from iOS Podfiles. - Removal of GMA from integration tests and UI tests. - Removal of GMA from build scripts and CI workflows. - Updates to documentation (README.md, Doxyfile) to reflect the removal, while preserving release notes related to past GMA versions and adding a new note about its removal.
❌ Integration test FAILEDRequested by @jonsimantov on commit 1e30f56
Add flaky tests to go/fpl-cpp-flake-tracker |
This commit removes the explicit print statement when skipping GMA-related encrypted files in `scripts/gha/restore_secrets.py`. The script will now silently ignore these files, aligning with the complete removal of the GMA SDK and avoiding unnecessary log output.
This commit ensures that `scripts/gha/restore_secrets.py` correctly skips processing for any GMA-related encrypted files. The existing check `if api == "gma": continue` should prevent attempts to write decrypted secrets to the `gma/integration_test` directory, which no longer exists after the removal of the GMA SDK. This submission is to confirm the CI tests against this version of the script.
This commit further refines `scripts/gha/restore_secrets.py` to prevent attempts to write to the deleted `gma/integration_test` directory. Changes include: - Initializing `dest_paths` as an empty list. - More careful construction of `dest_paths` based on whether `FLAGS.artifact` is set, ensuring that GMA paths are not inadvertently created. - Explicitly continuing the loop if no valid destination path is determined for a file, preventing unnecessary decryption or write attempts. - Adding redundant checks to ensure GMA paths are not processed before file write operations as a final safeguard. This should robustly address the `FileNotFoundError` previously observed in CI.
This commit removes print statements from `scripts/gha/restore_secrets.py` that were logging potentially sensitive file paths. This addresses security alerts raised by the GitHub Advanced Security bot regarding clear-text logging of sensitive information.
This commit simplifies the removal of the GMA SDK by deleting the `scripts/gha-encrypted/gma` directory entirely. This is a cleaner solution than adding skip logic to `restore_secrets.py` and resolves the `FileNotFoundError` in the CI by removing the source of the problem. The `restore_secrets.py` script has been reverted to its original state.
This commit ensures the complete removal of the GMA SDK by forcefully deleting the `scripts/gha-encrypted/gma` directory. This is the root cause of the `FileNotFoundError` in the CI and is the cleanest solution. The `restore_secrets.py` script remains in its original state, as the problem is resolved by removing the gma secrets it was attempting to process.
jonsimantov
commented
Jul 14, 2025
elif product == 'gma': | ||
product_name = product.upper() | ||
elif product == 'ump': | ||
product_name = product.upper() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restore this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the entire GMA C++ SDK from the Firebase C++ SDK, including all references to it across all platforms (iOS, Desktop, and Android).
Changes include:
gma
directory and its contents.Description
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.